ps2/masp
Watch
2
0
Fork
You've already forked masp
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Drop the unused regex.h include and the MinGW gnurx link #1

Merged
techwritescode merged 1 commit from drop-regex into master 2026-10-05 23:25:00 +00:00
Conversation 0 Commits 1 Files changed 2 -9
techwritescode commented 2026-10-05 23:24:17 +00:00
Owner
Copy link

masp includes <regex.h> but never calls it: the only regexec use in masp.c was already commented out. The include and the MinGW gnurx link are removed, so masp builds with the mingw-w64 cross toolchain, which has no regex.h. This lets the Windows masp.exe be cross-built from Linux instead of on a native Windows runner.

Verified:

  • Unmodified source under mingw fails with "regex.h: No such file or directory"; with this change it builds a static PE (imports KERNEL32.dll and msvcrt.dll only).
  • Unit tests pass (5 of 5) on Linux.
  • Old and new masp give byte-identical stdout, stderr and exit codes on the 10 test inputs and 20 real VCL files.
  • Cross-built masp.exe run on Windows matches the Linux output on 12 files. Through ps2gl's VU1 pipeline (pp1 to pp4, then openvcl) on all 13 renderers, the masp output and the resulting .vsm files are byte-identical to the previous native Windows masp.

🤖 Generated with Claude Code

masp includes <regex.h> but never calls it: the only regexec use in masp.c was already commented out. The include and the MinGW gnurx link are removed, so masp builds with the mingw-w64 cross toolchain, which has no regex.h. This lets the Windows masp.exe be cross-built from Linux instead of on a native Windows runner. Verified: - Unmodified source under mingw fails with "regex.h: No such file or directory"; with this change it builds a static PE (imports KERNEL32.dll and msvcrt.dll only). - Unit tests pass (5 of 5) on Linux. - Old and new masp give byte-identical stdout, stderr and exit codes on the 10 test inputs and 20 real VCL files. - Cross-built masp.exe run on Windows matches the Linux output on 12 files. Through ps2gl's VU1 pipeline (pp1 to pp4, then openvcl) on all 13 renderers, the masp output and the resulting .vsm files are byte-identical to the previous native Windows masp. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The only regexec call was commented out, so nothing used the regex API. Without the
include masp builds with the mingw-w64 cross toolchain, which has no regex.h.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
techwritescode deleted branch drop-regex 2026-10-05 23:25:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ps2/masp!1
No description provided.